classMethodVisibilityGuard = $classMethodVisibilityGuard; $this->visibilityManipulator = $visibilityManipulator; $this->reflectionResolver = $reflectionResolver; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Change static method and local-only calls to non-static', [new CodeSample(<<<'CODE_SAMPLE' class SomeClass { public function run() { self::someStatic(); } private static function someStatic() { } } CODE_SAMPLE , <<<'CODE_SAMPLE' class SomeClass { public function run() { $this->someStatic(); } private function someStatic() { } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [Class_::class]; } /** * @param Class_ $node */ public function refactor(Node $node) : ?Class_ { $hasChanged = \false; foreach ($node->getMethods() as $classMethod) { if (!$classMethod->isPrivate()) { continue; } $changedClassMethod = $this->refactorClassMethod($node, $classMethod); if ($changedClassMethod instanceof ClassMethod) { $hasChanged = \true; } } if ($hasChanged) { return $node; } return null; } private function refactorClassMethod(Class_ $class, ClassMethod $classMethod) : ?ClassMethod { if (!$classMethod->isStatic()) { return null; } $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod); if (!$classReflection instanceof ClassReflection) { return null; } if ($this->classMethodVisibilityGuard->isClassMethodVisibilityGuardedByParent($classMethod, $classReflection)) { return null; } if ($this->isClassMethodCalledInAnotherStaticClassMethod($class, $classMethod)) { return null; } // replace all the calls $classMethodName = $this->getName($classMethod); $className = $this->getName($class) ?? ''; $shouldSkip = \false; $this->traverseNodesWithCallable($class->getMethods(), function (Node $node) use(&$shouldSkip, $classMethodName, $className) : ?int { if (($node instanceof Closure || $node instanceof ArrowFunction) && $node->static) { $this->traverseNodesWithCallable($node->getStmts(), function (Node $subNode) use(&$shouldSkip, $classMethodName, $className) : ?int { if (!$subNode instanceof StaticCall) { return null; } if (!$this->isNames($subNode->class, ['self', 'static', $className])) { return null; } if (!$this->isName($subNode->name, $classMethodName)) { return null; } $shouldSkip = \true; return NodeTraverser::STOP_TRAVERSAL; }); if ($shouldSkip) { return NodeTraverser::STOP_TRAVERSAL; } return null; } return null; }); if ($shouldSkip) { return null; } $this->traverseNodesWithCallable($class->getMethods(), function (Node $node) use($classMethodName, $className) : ?MethodCall { if (!$node instanceof StaticCall) { return null; } if (!$this->isNames($node->class, ['self', 'static', $className])) { return null; } if (!$this->isName($node->name, $classMethodName)) { return null; } return new MethodCall(new Variable('this'), $classMethodName, $node->args); }); // change static calls to non-static ones, but only if in non-static method!!! $this->visibilityManipulator->makeNonStatic($classMethod); return $classMethod; } /** * If the static class method is called in another static class method, * we should keep it to avoid calling $this in static */ private function isClassMethodCalledInAnotherStaticClassMethod(Class_ $class, ClassMethod $classMethod) : bool { $currentClassNamespacedName = (string) $this->getName($class); $currentClassMethodName = $this->getName($classMethod); $isInsideStaticClassMethod = \false; // check if called stati call somewhere in class, but only in static methods foreach ($class->getMethods() as $checkedClassMethod) { // not a problem if (!$checkedClassMethod->isStatic()) { continue; } $this->traverseNodesWithCallable($checkedClassMethod, function (Node $node) use($currentClassNamespacedName, $currentClassMethodName, &$isInsideStaticClassMethod) : ?int { if (!$node instanceof StaticCall) { return null; } if (!$this->isNames($node->class, ['self', 'static', $currentClassNamespacedName])) { return null; } if (!$this->isName($node->name, $currentClassMethodName)) { return null; } $isInsideStaticClassMethod = \true; return NodeTraverser::STOP_TRAVERSAL; }); if ($isInsideStaticClassMethod) { return $isInsideStaticClassMethod; } } return \false; } }