foreachAnalyzer = $foreachAnalyzer; $this->valueResolver = $valueResolver; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Change foreach() items assign to empty array to direct assign', [new CodeSample(<<<'CODE_SAMPLE' class SomeClass { public function run($items) { $collectedItems = []; foreach ($items as $item) { $collectedItems[] = $item; } } } CODE_SAMPLE , <<<'CODE_SAMPLE' class SomeClass { public function run($items) { $collectedItems = []; $collectedItems = $items; } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [StmtsAwareInterface::class]; } /** * @param StmtsAwareInterface $node */ public function refactor(Node $node) : ?Node { if ($node->stmts === null) { return null; } $emptyArrayVariables = []; foreach ($node->stmts as $key => $stmt) { $variableName = $this->matchEmptyArrayVariableAssign($stmt); if (\is_string($variableName)) { $emptyArrayVariables[] = $variableName; } if (!$stmt instanceof Foreach_) { if ($this->isAppend($stmt, $emptyArrayVariables)) { return null; } continue; } if ($this->shouldSkip($stmt, $emptyArrayVariables)) { continue; } $assignVariable = $this->foreachAnalyzer->matchAssignItemsOnlyForeachArrayVariable($stmt); if (!$assignVariable instanceof Expr) { continue; } $directAssign = new Assign($assignVariable, $stmt->expr); $node->stmts[$key] = new Expression($directAssign); return $node; } return null; } /** * @param string[] $emptyArrayVariables */ private function isAppend(Stmt $stmt, array $emptyArrayVariables) : bool { $isAppend = \false; $this->traverseNodesWithCallable($stmt, function (Node $subNode) use($emptyArrayVariables, &$isAppend) : ?int { if ($subNode instanceof Assign && $subNode->var instanceof ArrayDimFetch) { $isAppend = $this->isNames($subNode->var->var, $emptyArrayVariables); if ($isAppend) { return NodeTraverser::STOP_TRAVERSAL; } } if ($subNode instanceof Assign && $subNode->var instanceof Variable && $this->isNames($subNode->var, $emptyArrayVariables) && !$this->valueResolver->isValue($subNode->expr, [])) { $isAppend = \true; return NodeTraverser::STOP_TRAVERSAL; } return null; }); return $isAppend; } /** * @param string[] $emptyArrayVariables */ private function shouldSkip(Foreach_ $foreach, array $emptyArrayVariables) : bool { $assignVariableExpr = $this->foreachAnalyzer->matchAssignItemsOnlyForeachArrayVariable($foreach); if (!$assignVariableExpr instanceof Expr) { return \true; } $foreachedExprType = $this->nodeTypeResolver->getNativeType($foreach->expr); // only arrays, not traversable/iterable if (!$foreachedExprType->isArray()->yes()) { return \true; } return !$this->isNames($assignVariableExpr, $emptyArrayVariables); } private function matchEmptyArrayVariableAssign(Stmt $stmt) : ?string { if (!$stmt instanceof Expression) { return null; } if (!$stmt->expr instanceof Assign) { return null; } $assign = $stmt->expr; if (!$assign->var instanceof Variable) { return null; } // must be assign of empty array if (!$this->valueResolver->isValue($assign->expr, [])) { return null; } return $this->getName($assign->var); } }