valueResolver = $valueResolver; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Simplify bool value compare to true or false', [new CodeSample(<<<'CODE_SAMPLE' class SomeClass { public function run(bool $value, string $items) { $match = in_array($value, $items, TRUE) === TRUE; $match = in_array($value, $items, TRUE) !== FALSE; } } CODE_SAMPLE , <<<'CODE_SAMPLE' class SomeClass { public function run(bool $value, string $items) { $match = in_array($value, $items, TRUE); $match = in_array($value, $items, TRUE); } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [Identical::class, NotIdentical::class]; } /** * @param Identical|NotIdentical $node */ public function refactor(Node $node) : ?Node { if ($this->isBooleanButNotTrueAndFalse($node->left)) { return $this->processBoolTypeToNotBool($node, $node->left, $node->right); } if ($this->isBooleanButNotTrueAndFalse($node->right)) { return $this->processBoolTypeToNotBool($node, $node->right, $node->left); } return null; } private function processBoolTypeToNotBool(Node $node, Expr $leftExpr, Expr $rightExpr) : ?Expr { if ($node instanceof Identical) { return $this->refactorIdentical($leftExpr, $rightExpr); } if ($node instanceof NotIdentical) { return $this->refactorNotIdentical($leftExpr, $rightExpr); } return null; } private function refactorIdentical(Expr $leftExpr, Expr $rightExpr) : ?Expr { if ($this->valueResolver->isTrue($rightExpr)) { return $leftExpr; } // prevent double negation !! if (!$this->valueResolver->isFalse($rightExpr)) { return null; } if (!$leftExpr instanceof BooleanNot) { return null; } return $leftExpr->expr; } private function refactorNotIdentical(Expr $leftExpr, Expr $rightExpr) : ?Expr { if ($this->valueResolver->isFalse($rightExpr)) { return $leftExpr; } if ($this->valueResolver->isTrue($rightExpr)) { return new BooleanNot($leftExpr); } return null; } private function isBooleanButNotTrueAndFalse(Expr $expr) : bool { if ($this->valueResolver->isTrueOrFalse($expr)) { return \false; } return $this->nodeTypeResolver->getNativeType($expr)->isBoolean()->yes(); } }