exprAnalyzer = $exprAnalyzer; $this->betterNodeFinder = $betterNodeFinder; $this->safeLeftTypeBooleanAndOrAnalyzer = $safeLeftTypeBooleanAndOrAnalyzer; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Remove if condition that is always true', [new CodeSample(<<<'CODE_SAMPLE' final class SomeClass { public function go() { if (1 === 1) { return 'yes'; } return 'no'; } } CODE_SAMPLE , <<<'CODE_SAMPLE' final class SomeClass { public function go() { return 'yes'; return 'no'; } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [If_::class]; } /** * @param If_ $node * @return int|null|Stmt[]|If_ */ public function refactor(Node $node) { if ($node->cond instanceof BooleanAnd) { return $this->refactorIfWithBooleanAnd($node); } if ($node->else instanceof Else_) { return null; } // just one if if ($node->elseifs !== []) { return null; } $conditionStaticType = $this->getType($node->cond); if (!$conditionStaticType instanceof ConstantBooleanType) { return null; } if (!$conditionStaticType->getValue()) { return null; } if ($this->shouldSkipExpr($node->cond)) { return null; } if ($this->shouldSkipFromVariable($node->cond)) { return null; } $hasAssign = (bool) $this->betterNodeFinder->findFirstInstanceOf($node->cond, Assign::class); if ($hasAssign) { return null; } if ($node->stmts === []) { return NodeTraverser::REMOVE_NODE; } return $node->stmts; } private function shouldSkipFromVariable(Expr $expr) : bool { /** @var Variable[] $variables */ $variables = $this->betterNodeFinder->findInstancesOf($expr, [Variable::class]); foreach ($variables as $variable) { if ($this->exprAnalyzer->isNonTypedFromParam($variable)) { return \true; } $type = $this->getType($variable); if ($type instanceof IntersectionType) { foreach ($type->getTypes() as $subType) { if ($subType instanceof ArrayType) { return \true; } } } } return \false; } private function shouldSkipExpr(Expr $expr) : bool { return (bool) $this->betterNodeFinder->findInstancesOf($expr, [PropertyFetch::class, StaticPropertyFetch::class, ArrayDimFetch::class, MethodCall::class, StaticCall::class]); } private function refactorIfWithBooleanAnd(If_ $if) : ?If_ { if (!$if->cond instanceof BooleanAnd) { return null; } $booleanAnd = $if->cond; $leftType = $this->getType($booleanAnd->left); if (!$leftType instanceof ConstantBooleanType) { return null; } if (!$leftType->getValue()) { return null; } if (!$this->safeLeftTypeBooleanAndOrAnalyzer->isSafe($booleanAnd)) { return null; } $if->cond = $booleanAnd->right; return $if; } }