exprAnalyzer = $exprAnalyzer; } public function provideMinPhpVersion() : int { return PhpVersionFeature::BINARY_OP_NUMBER_STRING; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Change binary operation between some number + string to PHP 7.1 compatible version', [new CodeSample(<<<'CODE_SAMPLE' class SomeClass { public function run() { $value = 5 + ''; $value = 5.0 + 'hi'; } } CODE_SAMPLE , <<<'CODE_SAMPLE' class SomeClass { public function run() { $value = 5 + 0; $value = 5.0 + 0.0; } } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [BinaryOp::class]; } /** * @param BinaryOp $node */ public function refactor(Node $node) : ?Node { if ($node instanceof Concat) { return null; } if ($node instanceof Coalesce) { return null; } if ($this->exprAnalyzer->isNonTypedFromParam($node->left)) { return null; } if ($this->exprAnalyzer->isNonTypedFromParam($node->right)) { return null; } if ($this->isStringOrStaticNonNumericString($node->left) && $this->nodeTypeResolver->isNumberType($node->right)) { $node->left = $this->nodeTypeResolver->getNativeType($node->right)->isInteger()->yes() ? new LNumber(0) : new DNumber(0); return $node; } if ($this->isStringOrStaticNonNumericString($node->right) && $this->nodeTypeResolver->isNumberType($node->left)) { $node->right = $this->nodeTypeResolver->getNativeType($node->left)->isInteger()->yes() ? new LNumber(0) : new DNumber(0); return $node; } return null; } private function isStringOrStaticNonNumericString(Expr $expr) : bool { // replace only scalar values, not variables/constants/etc. if (!$expr instanceof Scalar && !$expr instanceof Variable) { return \false; } if ($expr instanceof Line) { return \false; } if ($expr instanceof String_) { return !\is_numeric($expr->value); } $exprStaticType = $this->getType($expr); if ($exprStaticType instanceof ConstantStringType) { return !\is_numeric($exprStaticType->getValue()); } return \false; } }