visibilityManipulator = $visibilityManipulator; $this->parentPropertyLookupGuard = $parentPropertyLookupGuard; $this->reflectionResolver = $reflectionResolver; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Change property to private if possible', [new CodeSample(<<<'CODE_SAMPLE' final class SomeClass { protected $value; } CODE_SAMPLE , <<<'CODE_SAMPLE' final class SomeClass { private $value; } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [Class_::class]; } /** * @param Class_ $node */ public function refactor(Node $node) : ?Node { if (!$node->isFinal()) { return null; } $hasChanged = \false; $classReflection = $this->reflectionResolver->resolveClassReflection($node); if (!$classReflection instanceof ClassReflection) { return null; } foreach ($node->getProperties() as $property) { if ($this->shouldSkipProperty($property)) { continue; } if (!$this->parentPropertyLookupGuard->isLegal($property, $classReflection)) { continue; } $this->visibilityManipulator->makePrivate($property); $hasChanged = \true; } $construct = $node->getMethod(MethodName::CONSTRUCT); if ($construct instanceof ClassMethod) { foreach ($construct->params as $param) { if ($param->flags === 0) { continue; } if (!$this->visibilityManipulator->hasVisibility($param, Visibility::PROTECTED)) { continue; } if (!$this->parentPropertyLookupGuard->isLegal((string) $this->getName($param), $classReflection)) { continue; } $this->visibilityManipulator->makePrivate($param); $hasChanged = \true; } } if ($hasChanged) { return $node; } return null; } private function shouldSkipProperty(Property $property) : bool { if (\count($property->props) !== 1) { return \true; } return !$property->isProtected(); } }