nullableTypeAnalyzer = $nullableTypeAnalyzer; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Change && and || between nullable objects to instanceof compares', [new CodeSample(<<<'CODE_SAMPLE' function someFunction(?SomeClass $someClass) { if ($someClass && $someClass->someMethod()) { return 'yes'; } return 'no'; } CODE_SAMPLE , <<<'CODE_SAMPLE' function someFunction(?SomeClass $someClass) { if ($someClass instanceof SomeClass && $someClass->someMethod()) { return 'yes'; } return 'no'; } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [BooleanAnd::class, BooleanOr::class]; } /** * @param BooleanAnd|BooleanOr $node */ public function refactor(Node $node) : ?Node { if ($node instanceof BooleanOr) { return $this->processNegationBooleanOr($node); } return $this->processsNullableInstance($node); } /** * @param \PhpParser\Node\Expr\BinaryOp\BooleanAnd|\PhpParser\Node\Expr\BinaryOp\BooleanOr $node * @return null|\PhpParser\Node\Expr\BinaryOp\BooleanAnd|\PhpParser\Node\Expr\BinaryOp\BooleanOr */ private function processsNullableInstance($node) { $nullableObjectType = $this->nullableTypeAnalyzer->resolveNullableObjectType($node->left); $hasChanged = \false; if ($nullableObjectType instanceof ObjectType) { $node->left = $this->createExprInstanceof($node->left, $nullableObjectType); $hasChanged = \true; } $nullableObjectType = $this->nullableTypeAnalyzer->resolveNullableObjectType($node->right); if ($nullableObjectType instanceof ObjectType) { $node->right = $this->createExprInstanceof($node->right, $nullableObjectType); $hasChanged = \true; } if ($hasChanged) { return $node; } return null; } private function processNegationBooleanOr(BooleanOr $booleanOr) : ?BooleanOr { $hasChanged = \false; if ($booleanOr->left instanceof BooleanNot) { $nullableObjectType = $this->nullableTypeAnalyzer->resolveNullableObjectType($booleanOr->left->expr); if ($nullableObjectType instanceof ObjectType) { $booleanOr->left->expr = $this->createExprInstanceof($booleanOr->left->expr, $nullableObjectType); $hasChanged = \true; } } if ($booleanOr->right instanceof BooleanNot) { $nullableObjectType = $this->nullableTypeAnalyzer->resolveNullableObjectType($booleanOr->right->expr); if ($nullableObjectType instanceof ObjectType) { $booleanOr->right->expr = $this->createExprInstanceof($booleanOr->right->expr, $nullableObjectType); $hasChanged = \true; } } if ($hasChanged) { return $booleanOr; } /** @var BooleanOr|null $result */ $result = $this->processsNullableInstance($booleanOr); return $result; } private function createExprInstanceof(Expr $expr, ObjectType $objectType) : Instanceof_ { $fullyQualified = new FullyQualified($objectType->getClassName()); return new Instanceof_($expr, $fullyQualified); } }