allAssignNodePropertyTypeInferer = $allAssignNodePropertyTypeInferer; $this->makePropertyTypedGuard = $makePropertyTypedGuard; $this->reflectionResolver = $reflectionResolver; $this->valueResolver = $valueResolver; $this->phpAttributeAnalyzer = $phpAttributeAnalyzer; $this->scalarStringToTypeMapper = $scalarStringToTypeMapper; $this->staticTypeMapper = $staticTypeMapper; $this->constructorAssignDetector = $constructorAssignDetector; } public function getRuleDefinition() : RuleDefinition { return new RuleDefinition('Add typed property from JMS Serializer Type attribute', [new CodeSample(<<<'CODE_SAMPLE' final class SomeClass { #[\JMS\Serializer\Annotation\Type('string')] private $name; } CODE_SAMPLE , <<<'CODE_SAMPLE' final class SomeClass { #[\JMS\Serializer\Annotation\Type('string')] private ?string $name = null; } CODE_SAMPLE )]); } /** * @return array> */ public function getNodeTypes() : array { return [Class_::class]; } public function provideMinPhpVersion() : int { return PhpVersionFeature::ATTRIBUTES; } /** * @param Class_ $node */ public function refactor(Node $node) : ?Node { $hasChanged = \false; $classReflection = null; foreach ($node->getProperties() as $property) { if (!$property->isPrivate()) { continue; } if ($property->type instanceof Node) { continue; } if (!$this->phpAttributeAnalyzer->hasPhpAttribute($property, self::JMS_TYPE)) { continue; } if (!$classReflection instanceof ClassReflection) { $classReflection = $this->reflectionResolver->resolveClassReflection($node); } if (!$classReflection instanceof ClassReflection) { return null; } if (!$this->makePropertyTypedGuard->isLegal($property, $classReflection, \false)) { continue; } $inferredType = $this->allAssignNodePropertyTypeInferer->inferProperty($property, $classReflection, $this->file); // has assigned with type if ($inferredType instanceof Type) { continue; } if ($property->props[0]->default instanceof Node) { continue; } $typeValue = null; foreach ($property->attrGroups as $attrGroup) { foreach ($attrGroup->attrs as $attr) { if ($attr->name->toString() === self::JMS_TYPE) { $typeValue = $this->valueResolver->getValue($attr->args[0]->value); break; } } } if (!\is_string($typeValue)) { continue; } $typeValue = Strings::match($typeValue, '#\\w+#'); if (isset($typeValue[0]) && \is_string($typeValue[0])) { $type = $this->scalarStringToTypeMapper->mapScalarStringToType($typeValue[0]); if ($type instanceof MixedType) { $type = new ObjectType($typeValue[0]); } $propertyType = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($type, TypeKind::PROPERTY); if (!$propertyType instanceof Identifier && !$propertyType instanceof FullyQualified) { return null; } $isInConstructorAssigned = $this->constructorAssignDetector->isPropertyAssigned($node, $this->getName($property)); $type = $isInConstructorAssigned ? $propertyType : new NullableType($propertyType); $property->type = $type; if (!$isInConstructorAssigned) { $property->props[0]->default = new ConstFetch(new Name('null')); } $hasChanged = \true; } } if ($hasChanged) { return $node; } return null; } }